Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

St dh event log #237

Merged
merged 7 commits into from
Jul 6, 2020
Merged

St dh event log #237

merged 7 commits into from
Jul 6, 2020

Conversation

dhakim87
Copy link
Contributor

Adds schema change, new repo and new model object for representing an Event Log. This will be used initially to track emails we send out to end users.

Relevant to biocore/microsetta-admin#17

Copy link
Member

@wasade wasade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primary question is whether the event_time should be non-null

I really like this overall, and I can see how this event log could be expanded to capture other API events.

microsetta_private_api/db/patches/0065.sql Show resolved Hide resolved
microsetta_private_api/db/patches/0065.sql Outdated Show resolved Hide resolved
microsetta_private_api/db/patches/0065.sql Show resolved Hide resolved
microsetta_private_api/repo/event_log_repo.py Outdated Show resolved Hide resolved
… to be the 'slow' case insensitively search, since it turned out LIKE operators with suffix wildcards don't use the btree index in postgres 9.5
@wasade
Copy link
Member

wasade commented Jun 29, 2020

looks like something with travis is still running but am +1 after

@wasade wasade merged commit 3514d9b into master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants